block: make bioset_exit() fully resilient against being called twice
authorJens Axboe <axboe@kernel.dk>
Sun, 29 May 2022 13:13:09 +0000 (07:13 -0600)
committerJens Axboe <axboe@kernel.dk>
Sun, 29 May 2022 13:36:31 +0000 (07:36 -0600)
commit605f7415ecfb426610195dd6c7577b30592b3369
treefa9c0bb18d2267c20a6a6f69d719ea427989efe9
parentebd076bf7d5deef488ec7ebc3fdbf781eafae269
block: make bioset_exit() fully resilient against being called twice

Most of bioset_exit() is fine being called twice, as it clears the
various allocations etc when they are freed. The exception is
bio_alloc_cache_destroy(), which does not clear ->cache when it has
freed it.

This isn't necessarily a bug, but can be if buggy users does call the
exit path more then once, or with just a memset() bioset which has
never been initialized. dm appears to be one such user.

Fixes: be4d234d7aeb ("bio: add allocation cache abstraction")
Link: https://lore.kernel.org/linux-block/YpK7m+14A+pZKs5k@casper.infradead.org/
Reported-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bio.c