ovl: fix access beyond unterminated strings
authorAmir Goldstein <amir73il@gmail.com>
Fri, 28 Sep 2018 18:00:48 +0000 (21:00 +0300)
committerMiklos Szeredi <mszeredi@redhat.com>
Thu, 4 Oct 2018 12:49:10 +0000 (14:49 +0200)
commit601350ff58d5415a001769532f6b8333820e5786
tree56ac78548e6345a2f5c3a6d96dd5d9fe304d69ed
parent69383c5913a5d74b4aa7e2b78a5cf14ebfbba538
ovl: fix access beyond unterminated strings

KASAN detected slab-out-of-bounds access in printk from overlayfs,
because string format used %*s instead of %.*s.

> BUG: KASAN: slab-out-of-bounds in string+0x298/0x2d0 lib/vsprintf.c:604
> Read of size 1 at addr ffff8801c36c66ba by task syz-executor2/27811
>
> CPU: 0 PID: 27811 Comm: syz-executor2 Not tainted 4.19.0-rc5+ #36
...
>  printk+0xa7/0xcf kernel/printk/printk.c:1996
>  ovl_lookup_index.cold.15+0xe8/0x1f8 fs/overlayfs/namei.c:689

Reported-by: syzbot+376cea2b0ef340db3dd4@syzkaller.appspotmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 359f392ca53e ("ovl: lookup index entry for copy up origin")
Cc: <stable@vger.kernel.org> # v4.13
fs/overlayfs/namei.c