kvm: selftests: aarch64: fix the failure check in kvm_set_gsi_routing_irqchip_check
authorRicardo Koller <ricarkol@google.com>
Thu, 27 Jan 2022 03:08:56 +0000 (19:08 -0800)
committerMarc Zyngier <maz@kernel.org>
Tue, 8 Feb 2022 15:18:58 +0000 (15:18 +0000)
commit5b7898648f02083012900e48d063e51ccbdad165
tree9584eb702f590825292f2a7e453c937944a25d47
parent11024a7a0ac26dd31ddfa0f6590e158bdf9ab858
kvm: selftests: aarch64: fix the failure check in kvm_set_gsi_routing_irqchip_check

kvm_set_gsi_routing_irqchip_check(expect_failure=true) is used to check
the error code returned by the kernel when trying to setup an invalid
gsi routing table. The ioctl fails if "pin >= KVM_IRQCHIP_NUM_PINS", so
kvm_set_gsi_routing_irqchip_check() should test the error only when
"intid >= KVM_IRQCHIP_NUM_PINS+32". The issue is that the test check is
"intid >= KVM_IRQCHIP_NUM_PINS", so for a case like "intid =
KVM_IRQCHIP_NUM_PINS" the test wrongly assumes that the kernel will
return an error.  Fix this by using the right check.

Signed-off-by: Ricardo Koller <ricarkol@google.com>
Reported-by: Reiji Watanabe <reijiw@google.com>
Cc: Andrew Jones <drjones@redhat.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220127030858.3269036-4-ricarkol@google.com
tools/testing/selftests/kvm/aarch64/vgic_irq.c