drm/amdgpu: disallow direct upload save restore list from gfx driver
authorHawking Zhang <Hawking.Zhang@amd.com>
Mon, 4 Nov 2019 08:20:06 +0000 (16:20 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 6 Nov 2019 21:27:47 +0000 (16:27 -0500)
commit58f46d4b65021083ef4b4d49c6e2c58e5783f626
tree1bb6e064883013b7ef981c18e54dc9768cbcab6d
parentd7c5782acd354bdb5ed0fa10e1e397eaed558390
drm/amdgpu: disallow direct upload save restore list from gfx driver

Direct uploading save/restore list via mmio register writes breaks the security
policy. Instead, the driver should pass s&r list to psp.

For all the ASICs that use rlc v2_1 headers, the driver actually upload s&r list
twice, in non-psp ucode front door loading phase and gfx pg initialization phase.
The latter is not allowed.

VG12 is the only exception where the driver still keeps legacy approach for S&R
list uploading. In theory, this can be elimnated if we have valid srcntl ucode
for VG12.

Signed-off-by: Hawking Zhang <Hawking.Zhang@amd.com>
Reviewed-by: Candice Li <Candice.Li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c