fs, close_range: add flag CLOSE_RANGE_CLOEXEC
authorGiuseppe Scrivano <gscrivan@redhat.com>
Wed, 18 Nov 2020 10:47:45 +0000 (11:47 +0100)
committerChristian Brauner <christian.brauner@ubuntu.com>
Fri, 4 Dec 2020 11:06:15 +0000 (12:06 +0100)
commit582f1fb6b721facf04848d2ca57f34468da1813e
tree5e0e40e42885f4200940670bb06c1161acefa159
parent4e62d55d77bbdb33d821f5e16306caab38d42267
fs, close_range: add flag CLOSE_RANGE_CLOEXEC

When the flag CLOSE_RANGE_CLOEXEC is set, close_range doesn't
immediately close the files but it sets the close-on-exec bit.

It is useful for e.g. container runtimes that usually install a
seccomp profile "as late as possible" before execv'ing the container
process itself.  The container runtime could either do:
  1                                  2
- install_seccomp_profile();       - close_range(MIN_FD, MAX_INT, 0);
- close_range(MIN_FD, MAX_INT, 0); - install_seccomp_profile();
- execve(...);                     - execve(...);

Both alternative have some disadvantages.

In the first variant the seccomp_profile cannot block the close_range
syscall, as well as opendir/read/close/... for the fallback on older
kernels.
In the second variant, close_range() can be used only on the fds
that are not going to be needed by the runtime anymore, and it must be
potentially called multiple times to account for the different ranges
that must be closed.

Using close_range(..., ..., CLOSE_RANGE_CLOEXEC) solves these issues.
The runtime is able to use the existing open fds, the seccomp profile
can block close_range() and the syscalls used for its fallback.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Link: https://lore.kernel.org/r/20201118104746.873084-2-gscrivan@redhat.com
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
fs/file.c
include/uapi/linux/close_range.h