drm/amd/display: Use long for signed error code checks in commit planes
authorNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Thu, 2 May 2019 13:14:27 +0000 (09:14 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 6 May 2019 14:36:48 +0000 (09:36 -0500)
commit570c91d51b337053a90ac91710b5fa5d2aacd311
tree34621926cd71493a891731a0673b8ca3f9513c0d
parentb6818520edb0dc83d8de807cb40dff44995eab86
drm/amd/display: Use long for signed error code checks in commit planes

[Why]

The type of 'r' is uint32_t and the return codes for both:

- reservation_object_wait_timeout_rcu
- amdgpu_bo_reserve

...are signed. While it works for the latter since the check is
done on != 0 it doesn't work for the former since we check <= 0.

[How]

Make 'r' a long in commit planes so we're not doing any unsigned/signed
conversion here in the first place.

v2: use long instead of int (Christian)

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c