dm thin metadata: check if in fail_io mode when setting needs_check
authorMike Snitzer <snitzer@redhat.com>
Tue, 2 Jul 2019 19:50:08 +0000 (15:50 -0400)
committerMike Snitzer <snitzer@redhat.com>
Tue, 2 Jul 2019 19:50:08 +0000 (15:50 -0400)
commit54fa16ee532705985e6c946da455856f18f63ee1
tree5b019c4a77c281bb68e6d35f658e88b322c53beb
parent2eba4e640b2c4161e31ae20090a53ee02a518657
dm thin metadata: check if in fail_io mode when setting needs_check

Check if in fail_io mode at start of dm_pool_metadata_set_needs_check().
Otherwise dm_pool_metadata_set_needs_check()'s superblock_lock() can
crash in dm_bm_write_lock() while accessing the block manager object
that was previously destroyed as part of a failed
dm_pool_abort_metadata() that ultimately set fail_io to begin with.

Also, update DMERR() message to more accurately describe
superblock_lock() failure.

Cc: stable@vger.kernel.org
Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-thin-metadata.c