KVM: x86: Further clarify the logic and comments for toggling log dirty
authorSean Christopherson <seanjc@google.com>
Sat, 13 Feb 2021 00:50:11 +0000 (16:50 -0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 19 Feb 2021 08:08:34 +0000 (03:08 -0500)
commit52f4607940b18337f01d160aaae346eaac388bf7
treecffeedb01cccf2dc0d701e0c4519233140bee794
parenta018eba53870aa30e5e57465771cb209680f20c2
KVM: x86: Further clarify the logic and comments for toggling log dirty

Add a sanity check in kvm_mmu_slot_apply_flags to assert that the
LOG_DIRTY_PAGES flag is indeed being toggled, and explicitly rely on
that holding true when zapping collapsible SPTEs.  Manipulating the
CPU dirty log (PML) and write-protection also relies on this assertion,
but that's not obvious in the current code.

Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20210213005015.1651772-11-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/x86.c