cpuidle: poll_state: Avoid invoking local_clock() too often
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 27 Mar 2018 21:58:45 +0000 (23:58 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 29 Mar 2018 11:06:08 +0000 (13:06 +0200)
commit4dc2375c1a4e88ed2701f6961e0e4f9a7696ad3c
tree926f002833a8fc9afe9aaae3bc71114c43f9b0b7
parent64bdff698092aa6be28c3b248f887022eec77902
cpuidle: poll_state: Avoid invoking local_clock() too often

Rik reports that he sees an increase in CPU use in one benchmark
due to commit 612f1a22f067 "cpuidle: poll_state: Add time limit to
poll_idle()" that caused poll_idle() to call local_clock() in every
iteration of the loop.  Utilization increase generally means more
non-idle time with respect to total CPU time (on the average) which
implies reduced CPU frequency.

Doug reports that limiting the rate of local_clock() invocations
in there causes much less power to be drawn during a CPU-intensive
parallel workload (with idle states 1 and 2 disabled to enforce more
state 0 residency).

These two reports together suggest that executing local_clock() on
multiple CPUs in parallel at a high rate may cause chips to get hot
and trigger thermal/power limits on them to kick in, so reduce the
rate of local_clock() invocations in poll_idle() to avoid that issue.

Fixes: 612f1a22f067 "cpuidle: poll_state: Add time limit to poll_idle()"
Reported-by: Rik van Riel <riel@surriel.com>
Reported-by: Doug Smythies <dsmythies@telus.net>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: Rik van Riel <riel@surriel.com>
Reviewed-by: Rik van Riel <riel@surriel.com>
drivers/cpuidle/poll_state.c