drm: Set vm_ops to GEM object's values during mmap
authorThomas Zimmermann <tzimmermann@suse.de>
Fri, 15 Jan 2021 09:30:38 +0000 (10:30 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 18 Jan 2021 09:37:26 +0000 (10:37 +0100)
commit47d35c1c40d53411d77d214644e12734901c553c
tree6b50742985e3bb4b2723c8f1e14d0d14e81fda38
parent85dd1dd6e27147efe68539ef52802a7fa579f6cf
drm: Set vm_ops to GEM object's values during mmap

The GEM mmap code relies on the GEM object's mmap callback to set the
VMA's vm_ops field. This is easily forgotten and already led to a memory
leak in the CMA helpers. Instead set the vm_ops field in the DRM core
code to the GEM object's value. Drivers with different needs can override
this in their mmap callback.

v2:
* support (vm_ops == NULL) if mmap is given; required by VRAM
  helpers

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: f5ca8eb6f9bd ("drm/cma-helper: Implement mmap as GEM CMA object functions")
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reported-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Tested-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org
Link: https://patchwork.freedesktop.org/patch/msgid/20210115093038.10345-1-tzimmermann@suse.de
drivers/gpu/drm/drm_gem.c
drivers/gpu/drm/drm_prime.c