dm thin metadata: use pool locking at end of dm_pool_metadata_close
authorMike Snitzer <snitzer@redhat.com>
Mon, 13 Jan 2020 16:18:51 +0000 (11:18 -0500)
committerMike Snitzer <snitzer@redhat.com>
Wed, 15 Jan 2020 01:22:49 +0000 (20:22 -0500)
commit44d8ebf436399a40fcd10dd31b29d37823d62fcc
tree13924061f11d7bea86664d5a8149d20b8b6bb560
parentaa9509209c5ac2f0b35d01a922bf9ae072d0c2fc
dm thin metadata: use pool locking at end of dm_pool_metadata_close

Ensure that the pool is locked during calls to __commit_transaction and
__destroy_persistent_data_objects.  Just being consistent with locking,
but reality is dm_pool_metadata_close is called once pool is being
destroyed so access to pool shouldn't be contended.

Also, use pmd_write_lock_in_core rather than __pmd_write_lock in
dm_pool_commit_metadata and rename __pmd_write_lock to
pmd_write_lock_in_core -- there was no need for the alias.

In addition, verify that the pool is locked in __commit_transaction().

Fixes: 873f258becca ("dm thin metadata: do not write metadata if no changes occurred")
Cc: stable@vger.kernel.org
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-thin-metadata.c