openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT
authorAleksa Sarai <cyphar@cyphar.com>
Tue, 27 Oct 2020 23:50:43 +0000 (10:50 +1100)
committerChristian Brauner <christian.brauner@ubuntu.com>
Thu, 3 Dec 2020 09:15:50 +0000 (10:15 +0100)
commit398840f8bb935d33c64df4ec4fed77a7d24c267d
tree0a5bb96cba43ad586043b0fd121eefc558444d80
parentb65054597872ce3aefbc6a666385eabdf9e288da
openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT

This was an oversight in the original implementation, as it makes no
sense to specify both scoping flags to the same openat2(2) invocation
(before this patch, the result of such an invocation was equivalent to
RESOLVE_IN_ROOT being ignored).

This is a userspace-visible ABI change, but the only user of openat2(2)
at the moment is LXC which doesn't specify both flags and so no
userspace programs will break as a result.

Fixes: fddb5d430ad9 ("open: introduce openat2(2) syscall")
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Cc: <stable@vger.kernel.org> # v5.6+
Link: https://lore.kernel.org/r/20201027235044.5240-2-cyphar@cyphar.com
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
fs/open.c