Fix compat regression in process_vm_rw()
authorJens Axboe <axboe@kernel.dk>
Tue, 27 Oct 2020 00:03:18 +0000 (18:03 -0600)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 27 Oct 2020 16:57:46 +0000 (09:57 -0700)
commit38dc5079da7081e8b09b14e255e9da82c451a531
treef1c872f5a3cad39a3ac3d69766f3ccb0b56916f0
parent4525c8781ec0701ce824e8bd379ae1b129e26568
Fix compat regression in process_vm_rw()

The removal of compat_process_vm_{readv,writev} didn't change
process_vm_rw(), which always assumes it's not doing a compat syscall.

Instead of passing in 'false' unconditionally for 'compat', make it
conditional on in_compat_syscall().

[ Both Al and Christoph point out that trying to access a 64-bit process
  from a 32-bit one cannot work anyway, and is likely better prohibited,
  but that's a separate issue    - Linus ]

Fixes: c3973b401ef2 ("mm: remove compat_process_vm_{readv,writev}")
Reported-and-tested-by: Kyle Huey <me@kylehuey.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/process_vm_access.c