drm/amd/display: check attr flag before set cursor degamma on DCN3+
authorMelissa Wen <mwen@igalia.com>
Mon, 31 Jul 2023 08:35:05 +0000 (07:35 -0100)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 7 Aug 2023 21:13:09 +0000 (17:13 -0400)
commit30a56f3243b2bf35f780e8a9a9b36560ee6acb66
tree6c487aab43b93a6ef97232807b3ac3cfecf27065
parentdbca8310c8ad5901589d0af1188d81347dd27aa8
drm/amd/display: check attr flag before set cursor degamma on DCN3+

Don't set predefined degamma curve to cursor plane if the cursor
attribute flag is not set. Applying a degamma curve to the cursor by
default breaks userspace expectation. Checking the flag before
performing any color transformation prevents too dark cursor gamma in
DCN3+ on many Linux desktop environment (KDE Plasma, GNOME,
wlroots-based, etc.) as reported at:
- https://gitlab.freedesktop.org/drm/amd/-/issues/1513

This is the same approach followed by DCN2 drivers where the issue is
not present.

Fixes: 03f54d7d3448 ("drm/amd/display: Add DCN3 DPP")
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1513
Signed-off-by: Melissa Wen <mwen@igalia.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Tested-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c