media: i2c: adv7511-v4l2: fix possible use-after-free in adv7511_remove()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 6 Apr 2021 13:48:12 +0000 (15:48 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 9 Apr 2021 10:54:00 +0000 (12:54 +0200)
commit2c9541720c66899adf6f3600984cf3ef151295ad
tree0fe1bbc08b090e4fe72d6701cfad84586e94849b
parentfa56f5f1fe31c2050675fa63b84963ebd504a5b3
media: i2c: adv7511-v4l2: fix possible use-after-free in adv7511_remove()

This driver's remove path calls cancel_delayed_work(). However, that
function does not wait until the work function finishes. This means
that the callback function may still be running after the driver's
remove function has finished, which would result in a use-after-free.

Fix by calling cancel_delayed_work_sync(), which ensures that
the work is properly cancelled, no longer running, and unable
to re-schedule itself.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/adv7511-v4l2.c