wil6210: check len before memcpy() calls
authorDenis Efremov <efremov@linux.com>
Tue, 1 Oct 2019 12:08:23 +0000 (15:08 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 2 Oct 2019 17:22:59 +0000 (20:22 +0300)
commit2c840676be8ffc624bf9bb4490d944fd13c02d71
tree60af9e4f60e1303e47290e8aa64ef9106f9a70ad
parent315cee426f87658a6799815845788fde965ddaad
wil6210: check len before memcpy() calls

memcpy() in wmi_set_ie() and wmi_update_ft_ies() is called with
src == NULL and len == 0. This is an undefined behavior. Fix it
by checking "ie_len > 0" before the memcpy() calls.

As suggested by GCC documentation:
"The pointers passed to memmove (and similar functions in <string.h>)
must be non-null even when nbytes==0, so GCC can use that information
to remove the check after the memmove call." [1]

[1] https://gcc.gnu.org/gcc-4.9/porting_to.html

Cc: Maya Erez <merez@codeaurora.org>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: stable@vger.kernel.org
Signed-off-by: Denis Efremov <efremov@linux.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/wil6210/wmi.c