drm/vmwgfx: fix potential UAF in vmwgfx_surface.c
authorDesmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Sat, 24 Jul 2021 11:18:24 +0000 (19:18 +0800)
committerZack Rusin <zackr@vmware.com>
Mon, 9 Aug 2021 21:30:34 +0000 (17:30 -0400)
commit2bc5da528dd570c5ecabc107e6fbdbc55974276f
tree17db96c2cf7aab94f4d2a9c90ddf6a1e24d5b783
parent1cb48cf3b1da45e0bfb5046d2d43746dbdd6339e
drm/vmwgfx: fix potential UAF in vmwgfx_surface.c

drm_file.master should be protected by either drm_device.master_mutex
or drm_file.master_lookup_lock when being dereferenced. However,
drm_master_get is called on unprotected file_priv->master pointers in
vmw_surface_define_ioctl and vmw_gb_surface_define_internal.

This is fixed by replacing drm_master_get with drm_file_get_master.

Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Zack Rusin <zackr@vmware.com>
Signed-off-by: Zack Rusin <zackr@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210724111824.59266-4-desmondcheongzx@gmail.com
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c