perf config: Fix caching and memory leak in perf_home_perfconfig()
authorArnaldo Carvalho de Melo <acme@kernel.org>
Fri, 20 Aug 2021 14:13:36 +0000 (11:13 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 30 Aug 2021 13:06:22 +0000 (10:06 -0300)
commit261f491133aecb943ccfdc3b3794e2d775607a87
treeb5e19a97e68bd5d2bf39e89a98e5138455749e79
parent128dbd78bd673f9edbc4413072b23efb6657feb0
perf config: Fix caching and memory leak in perf_home_perfconfig()

Acaict, perf_home_perfconfig() is supposed to cache the result of
home_perfconfig, which returns the default location of perfconfig for
the user, given the HOME environment variable.

However, the current implementation calls home_perfconfig every time
perf_home_perfconfig() is called (so no caching is actually performed),
replacing the previous pointer, thus also causing a memory leak.

This patch adds a check of whether either config or failed is set and,
in that case, directly returns config without calling home_perfconfig at
each invocation.

Fixes: f5f03e19ce14fc31 ("perf config: Add perf_home_perfconfig function")
Signed-off-by: Riccardo Mancini <rickyman7@gmail.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <song@kernel.org>
Link: http://lore.kernel.org/lkml/20210820130817.740536-1-rickyman7@gmail.com
[ Removed needless double check for the 'failed' variable ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/config.c