KVM: arm64: Hide system instruction access to Trace registers
authorSuzuki K Poulose <suzuki.poulose@arm.com>
Tue, 23 Mar 2021 12:06:29 +0000 (12:06 +0000)
committerMarc Zyngier <maz@kernel.org>
Wed, 24 Mar 2021 17:26:38 +0000 (17:26 +0000)
commit1d676673d665fd2162e7e466dcfbe5373bfdb73e
tree1584bf87ea3ccb9b0787a1ffbdb01a1f953e318c
parent1e28eed17697bcf343c6743f0028cc3b5dd88bf0
KVM: arm64: Hide system instruction access to Trace registers

Currently we advertise the ID_AA6DFR0_EL1.TRACEVER for the guest,
when the trace register accesses are trapped (CPTR_EL2.TTA == 1).
So, the guest will get an undefined instruction, if trusts the
ID registers and access one of the trace registers.
Lets be nice to the guest and hide the feature to avoid
unexpected behavior.

Even though this can be done at KVM sysreg emulation layer,
we do this by removing the TRACEVER from the sanitised feature
register field. This is fine as long as the ETM drivers
can handle the individual trace units separately, even
when there are differences among the CPUs.

Cc: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210323120647.454211-2-suzuki.poulose@arm.com
arch/arm64/kernel/cpufeature.c