scsi: sym53c8xx_2: Fix sizeof() mismatch
authorColin Ian King <colin.king@canonical.com>
Tue, 6 Oct 2020 11:02:52 +0000 (12:02 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 8 Oct 2020 03:50:04 +0000 (23:50 -0400)
commit1725ba8d6ff1e98ce9d1f79d2bad7580cceace05
tree733627dba7dc5b17853d43a96ce0544fe2da1855
parent45660591ee8f5b08bfc6e3aec50639df82a19ca3
scsi: sym53c8xx_2: Fix sizeof() mismatch

An incorrect sizeof() is being used, struct sym_ccb ** is not correct, it
should be struct sym_ccb *. Note that since ** is the same size as * this
is not causing any issues.  Improve this fix by using the idiom
sizeof(*np->ccbh) as this allows one to not even reference the type of the
pointer.

[ Note: this is an ancient 2005 buglet, the sha is from the
  tglx/history repo ]

Link: https://lore.kernel.org/r/20201006110252.536641-1-colin.king@canonical.com
Fixes: 473c67f96e06 ("[PATCH] sym2 version 2.2.0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)")
drivers/scsi/sym53c8xx_2/sym_hipd.c