nvme: Don't use a stack buffer for keep-alive command
authorRoland Dreier <roland@purestorage.com>
Thu, 11 Jan 2018 21:38:15 +0000 (13:38 -0800)
committerSagi Grimberg <sagi@grimberg.me>
Mon, 12 Feb 2018 20:18:14 +0000 (22:18 +0200)
commit0a34e4668c508cbbc2d5ef2d9710b145e4c0b27d
tree53697e55ea1cfe7236ccac678c0a2ac6b103a9d9
parentc3aedd225f8bcc3b3e61df074bc045b80542b38a
nvme: Don't use a stack buffer for keep-alive command

In nvme_keep_alive() we pass a request with a pointer to an NVMe command on
the stack into blk_execute_rq_nowait().  However, the block layer doesn't
guarantee that the request is fully queued before blk_execute_rq_nowait()
returns.  If not, and the request is queued after nvme_keep_alive() returns,
then we'll end up using stack memory that might have been overwritten to
form the NVMe command we pass to hardware.

Fix this by keeping a special command struct in the nvme_ctrl struct right
next to the delayed work struct used for keep-alives.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
drivers/nvme/host/core.c
drivers/nvme/host/nvme.h