sctp: do not update transport pathmtu if SPP_PMTUD_ENABLE is not set
authorXin Long <lucien.xin@gmail.com>
Wed, 21 Jul 2021 18:45:54 +0000 (14:45 -0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Jul 2021 21:17:58 +0000 (14:17 -0700)
commit02dc2ee7c7476dd831df63d2b10cc0a162a531f1
treecf16b67c5599314cd1873615f56815475ca457cf
parent161dcc02428858fe338b7493158ed6f5fc2a8f26
sctp: do not update transport pathmtu if SPP_PMTUD_ENABLE is not set

Currently, in sctp_packet_config(), sctp_transport_pmtu_check() is
called to update transport pathmtu with dst's mtu when dst's mtu
has been changed by non sctp stack like xfrm.

However, this should only happen when SPP_PMTUD_ENABLE is set, no
matter where dst's mtu changed. This patch is to fix by checking
SPP_PMTUD_ENABLE flag before calling sctp_transport_pmtu_check().

Thanks Jacek for reporting and looking into this issue.

v1->v2:
  - add the missing "{" to fix the build error.

Fixes: 69fec325a643 ('Revert "sctp: remove sctp_transport_pmtu_check"')
Reported-by: Jacek Szafraniec <jacek.szafraniec@nokia.com>
Tested-by: Jacek Szafraniec <jacek.szafraniec@nokia.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/output.c