Merge tag 'drm-misc-next-fixes-2021-09-09' of git://anongit.freedesktop.org/drm/drm...
[linux-2.6-microblaze.git] / drivers / gpu / drm / msm / msm_drv.c
index 9b8fa2a..2e6fc18 100644 (file)
@@ -14,7 +14,6 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_file.h>
 #include <drm/drm_ioctl.h>
-#include <drm/drm_irq.h>
 #include <drm/drm_prime.h>
 #include <drm/drm_of.h>
 #include <drm/drm_vblank.h>
@@ -201,6 +200,71 @@ void msm_rmw(void __iomem *addr, u32 mask, u32 or)
        msm_writel(val | or, addr);
 }
 
+static irqreturn_t msm_irq(int irq, void *arg)
+{
+       struct drm_device *dev = arg;
+       struct msm_drm_private *priv = dev->dev_private;
+       struct msm_kms *kms = priv->kms;
+
+       BUG_ON(!kms);
+
+       return kms->funcs->irq(kms);
+}
+
+static void msm_irq_preinstall(struct drm_device *dev)
+{
+       struct msm_drm_private *priv = dev->dev_private;
+       struct msm_kms *kms = priv->kms;
+
+       BUG_ON(!kms);
+
+       kms->funcs->irq_preinstall(kms);
+}
+
+static int msm_irq_postinstall(struct drm_device *dev)
+{
+       struct msm_drm_private *priv = dev->dev_private;
+       struct msm_kms *kms = priv->kms;
+
+       BUG_ON(!kms);
+
+       if (kms->funcs->irq_postinstall)
+               return kms->funcs->irq_postinstall(kms);
+
+       return 0;
+}
+
+static int msm_irq_install(struct drm_device *dev, unsigned int irq)
+{
+       int ret;
+
+       if (irq == IRQ_NOTCONNECTED)
+               return -ENOTCONN;
+
+       msm_irq_preinstall(dev);
+
+       ret = request_irq(irq, msm_irq, 0, dev->driver->name, dev);
+       if (ret)
+               return ret;
+
+       ret = msm_irq_postinstall(dev);
+       if (ret) {
+               free_irq(irq, dev);
+               return ret;
+       }
+
+       return 0;
+}
+
+static void msm_irq_uninstall(struct drm_device *dev)
+{
+       struct msm_drm_private *priv = dev->dev_private;
+       struct msm_kms *kms = priv->kms;
+
+       kms->funcs->irq_uninstall(kms);
+       free_irq(kms->irq, dev);
+}
+
 struct msm_vblank_work {
        struct work_struct work;
        int crtc_id;
@@ -265,7 +329,7 @@ static int msm_drm_uninit(struct device *dev)
        }
 
        /* We must cancel and cleanup any pending vblank enable/disable
-        * work before drm_irq_uninstall() to avoid work re-enabling an
+        * work before msm_irq_uninstall() to avoid work re-enabling an
         * irq after uninstall has disabled it.
         */
 
@@ -294,7 +358,7 @@ static int msm_drm_uninit(struct device *dev)
        drm_mode_config_cleanup(ddev);
 
        pm_runtime_get_sync(dev);
-       drm_irq_uninstall(ddev);
+       msm_irq_uninstall(ddev);
        pm_runtime_put_sync(dev);
 
        if (kms && kms->funcs)
@@ -539,6 +603,7 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv)
                if (IS_ERR(priv->event_thread[i].worker)) {
                        ret = PTR_ERR(priv->event_thread[i].worker);
                        DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n");
+                       ret = PTR_ERR(priv->event_thread[i].worker);
                        goto err_msm_uninit;
                }
 
@@ -553,7 +618,7 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv)
 
        if (kms) {
                pm_runtime_get_sync(dev);
-               ret = drm_irq_install(ddev, kms->irq);
+               ret = msm_irq_install(ddev, kms->irq);
                pm_runtime_put_sync(dev);
                if (ret < 0) {
                        DRM_DEV_ERROR(dev, "failed to install IRQ handler\n");
@@ -662,43 +727,6 @@ static void msm_postclose(struct drm_device *dev, struct drm_file *file)
        context_close(ctx);
 }
 
-static irqreturn_t msm_irq(int irq, void *arg)
-{
-       struct drm_device *dev = arg;
-       struct msm_drm_private *priv = dev->dev_private;
-       struct msm_kms *kms = priv->kms;
-       BUG_ON(!kms);
-       return kms->funcs->irq(kms);
-}
-
-static void msm_irq_preinstall(struct drm_device *dev)
-{
-       struct msm_drm_private *priv = dev->dev_private;
-       struct msm_kms *kms = priv->kms;
-       BUG_ON(!kms);
-       kms->funcs->irq_preinstall(kms);
-}
-
-static int msm_irq_postinstall(struct drm_device *dev)
-{
-       struct msm_drm_private *priv = dev->dev_private;
-       struct msm_kms *kms = priv->kms;
-       BUG_ON(!kms);
-
-       if (kms->funcs->irq_postinstall)
-               return kms->funcs->irq_postinstall(kms);
-
-       return 0;
-}
-
-static void msm_irq_uninstall(struct drm_device *dev)
-{
-       struct msm_drm_private *priv = dev->dev_private;
-       struct msm_kms *kms = priv->kms;
-       BUG_ON(!kms);
-       kms->funcs->irq_uninstall(kms);
-}
-
 int msm_crtc_enable_vblank(struct drm_crtc *crtc)
 {
        struct drm_device *dev = crtc->dev;
@@ -911,6 +939,7 @@ static int msm_ioctl_wait_fence(struct drm_device *dev, void *data,
        ktime_t timeout = to_ktime(args->timeout);
        struct msm_gpu_submitqueue *queue;
        struct msm_gpu *gpu = priv->gpu;
+       struct dma_fence *fence;
        int ret;
 
        if (args->pad) {
@@ -925,10 +954,35 @@ static int msm_ioctl_wait_fence(struct drm_device *dev, void *data,
        if (!queue)
                return -ENOENT;
 
-       ret = msm_wait_fence(gpu->rb[queue->prio]->fctx, args->fence, &timeout,
-               true);
+       /*
+        * Map submitqueue scoped "seqno" (which is actually an idr key)
+        * back to underlying dma-fence
+        *
+        * The fence is removed from the fence_idr when the submit is
+        * retired, so if the fence is not found it means there is nothing
+        * to wait for
+        */
+       ret = mutex_lock_interruptible(&queue->lock);
+       if (ret)
+               return ret;
+       fence = idr_find(&queue->fence_idr, args->fence);
+       if (fence)
+               fence = dma_fence_get_rcu(fence);
+       mutex_unlock(&queue->lock);
+
+       if (!fence)
+               return 0;
+
+       ret = dma_fence_wait_timeout(fence, true, timeout_to_jiffies(&timeout));
+       if (ret == 0) {
+               ret = -ETIMEDOUT;
+       } else if (ret != -ERESTARTSYS) {
+               ret = 0;
+       }
 
+       dma_fence_put(fence);
        msm_submitqueue_put(queue);
+
        return ret;
 }
 
@@ -1004,17 +1058,7 @@ static const struct drm_ioctl_desc msm_ioctls[] = {
        DRM_IOCTL_DEF_DRV(MSM_SUBMITQUEUE_QUERY, msm_ioctl_submitqueue_query, DRM_RENDER_ALLOW),
 };
 
-static const struct file_operations fops = {
-       .owner              = THIS_MODULE,
-       .open               = drm_open,
-       .release            = drm_release,
-       .unlocked_ioctl     = drm_ioctl,
-       .compat_ioctl       = drm_compat_ioctl,
-       .poll               = drm_poll,
-       .read               = drm_read,
-       .llseek             = no_llseek,
-       .mmap               = msm_gem_mmap,
-};
+DEFINE_DRM_GEM_FOPS(fops);
 
 static const struct drm_driver msm_driver = {
        .driver_features    = DRIVER_GEM |
@@ -1025,16 +1069,12 @@ static const struct drm_driver msm_driver = {
        .open               = msm_open,
        .postclose           = msm_postclose,
        .lastclose          = drm_fb_helper_lastclose,
-       .irq_handler        = msm_irq,
-       .irq_preinstall     = msm_irq_preinstall,
-       .irq_postinstall    = msm_irq_postinstall,
-       .irq_uninstall      = msm_irq_uninstall,
        .dumb_create        = msm_gem_dumb_create,
        .dumb_map_offset    = msm_gem_dumb_map_offset,
        .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
        .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
        .gem_prime_import_sg_table = msm_gem_prime_import_sg_table,
-       .gem_prime_mmap     = msm_gem_prime_mmap,
+       .gem_prime_mmap     = drm_gem_prime_mmap,
 #ifdef CONFIG_DEBUG_FS
        .debugfs_init       = msm_debugfs_init,
 #endif