Merge tag 'gpio-fixes-for-v5.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel...

[linux-2.6-microblaze.git] / drivers / gpio / gpio-ts4900.c

diff --git a/drivers/gpio/gpio-ts4900.c b/drivers/gpio/gpio-ts4900.c
index d918d2d..416725c 100644 (file)
--- a/drivers/gpio/gpio-ts4900.c
+++ b/drivers/gpio/gpio-ts4900.c
@@ -1,17 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Digital I/O driver for Technologic Systems I2C FPGA Core
  *
  * Copyright (C) 2015, 2018 Technologic Systems
  * Copyright (C) 2016 Savoir-Faire Linux
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed "as is" WITHOUT ANY WARRANTY of any
- * kind, whether expressed or implied; without even the implied warranty
- * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License version 2 for more details.
  */
 
 #include <linux/gpio/driver.h>
@@ -55,8 +47,9 @@ static int ts4900_gpio_direction_input(struct gpio_chip *chip,
 {
        struct ts4900_gpio_priv *priv = gpiochip_get_data(chip);
 
-       /* Only clear the OE bit here, requires a RMW. Prevents potential issue
-        * with OE and data getting to the physical pin at different times.
+       /*
+        * Only clear the OE bit here, requires a RMW. Prevents a potential issue
+        * with OE and DAT getting to the physical pin at different times.
         */
        return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0);
 }
@@ -68,9 +61,10 @@ static int ts4900_gpio_direction_output(struct gpio_chip *chip,
        unsigned int reg;
        int ret;
 
-       /* If changing from an input to an output, we need to first set the
-        * proper data bit to what is requested and then set OE bit. This
-        * prevents a glitch that can occur on the IO line
+       /*
+        * If changing from an input to an output, we need to first set the
+        * GPIO's DAT bit to what is requested and then set the OE bit. This
+        * prevents a glitch that can occur on the IO line.
         */
        regmap_read(priv->regmap, offset, &reg);
        if (!(reg & TS4900_GPIO_OE)) {