From 982c34e0c2a5801459af2bd5aa5b63825793b0e3 Mon Sep 17 00:00:00 2001 From: Bhanusree Pola Date: Sun, 17 Mar 2019 16:31:33 +0530 Subject: [PATCH] staging: mt7621-mmc: Fix ret.cooci warnings Return the value directly instead of storing it in local variable err. Remove the unused local variable err. The semantic patch that fixes the first part of the problem is as follows // @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; // Signed-off-by: Bhanusree Pola Signed-off-by: Greg Kroah-Hartman --- drivers/staging/mt7621-mmc/sd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index 4b26ec896a96..8857cdb9dafd 100644 --- a/drivers/staging/mt7621-mmc/sd.c +++ b/drivers/staging/mt7621-mmc/sd.c @@ -752,7 +752,6 @@ static int msdc_app_cmd(struct mmc_host *mmc, struct msdc_host *host) { struct mmc_command cmd; struct mmc_request mrq; - u32 err; memset(&cmd, 0, sizeof(struct mmc_command)); cmd.opcode = MMC_APP_CMD; @@ -763,8 +762,7 @@ static int msdc_app_cmd(struct mmc_host *mmc, struct msdc_host *host) mrq.cmd = &cmd; cmd.mrq = &mrq; cmd.data = NULL; - err = msdc_do_command(host, &cmd, 0, CMD_TIMEOUT); - return err; + return msdc_do_command(host, &cmd, 0, CMD_TIMEOUT); } static int msdc_tune_cmdrsp(struct msdc_host *host, struct mmc_command *cmd) -- 2.20.1