padata: avoid UAF for reorder_work
authorChen Ridong <chenridong@huawei.com>
Fri, 10 Jan 2025 06:16:39 +0000 (06:16 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sun, 19 Jan 2025 04:44:28 +0000 (12:44 +0800)
commitdd7d37ccf6b11f3d95e797ebe4e9e886d0332600
tree1f58134fa408ab99f8f6e1eed438061ceb8c2902
parente01780ea4661172734118d2a5f41bc9720765668
padata: avoid UAF for reorder_work

Although the previous patch can avoid ps and ps UAF for _do_serial, it
can not avoid potential UAF issue for reorder_work. This issue can
happen just as below:

crypto_request crypto_request crypto_del_alg
padata_do_serial
  ...
  padata_reorder
    // processes all remaining
    // requests then breaks
    while (1) {
      if (!padata)
        break;
      ...
    }

padata_do_serial
  // new request added
  list_add
    // sees the new request
    queue_work(reorder_work)
  padata_reorder
    queue_work_on(squeue->work)
...

<kworker context>
padata_serial_worker
// completes new request,
// no more outstanding
// requests

crypto_del_alg
  // free pd

<kworker context>
invoke_padata_reorder
  // UAF of pd

To avoid UAF for 'reorder_work', get 'pd' ref before put 'reorder_work'
into the 'serial_wq' and put 'pd' ref until the 'serial_wq' finish.

Fixes: bbefa1dd6a6d ("crypto: pcrypt - Avoid deadlock by using per-instance padata queues")
Signed-off-by: Chen Ridong <chenridong@huawei.com>
Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
kernel/padata.c