Makefile: Do not quote value for CONFIG_CC_IMPLICIT_FALLTHROUGH
authorSalvatore Bonaccorso <carnil@debian.org>
Mon, 6 Dec 2021 20:42:01 +0000 (21:42 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 7 Dec 2021 00:42:47 +0000 (16:42 -0800)
commitcd8c917a56f20f48748dd43d9ae3caff51d5b987
tree0ca0f2690ea555044fff6670b660b1117dba5560
parentf80ef9e49fdfbfbc4197711230098b90e6b05a7e
Makefile: Do not quote value for CONFIG_CC_IMPLICIT_FALLTHROUGH

Andreas reported that a specific build environment for an external
module, being a bit broken, does pass CC_IMPLICIT_FALLTHROUGH quoted as
argument to gcc, causing an error

  gcc-11: error: "-Wimplicit-fallthrough=5": linker input file not found: No such file or directory

Until this is more generally fixed as outlined in [1], by fixing
scripts/link-vmlinux.sh, scripts/gen_autoksyms.sh, etc to not directly
include the include/config/auto.conf, and in a second step, change
Kconfig to generate the auto.conf without "", workaround the issue by
explicitly unquoting CC_IMPLICIT_FALLTHROUGH.

Reported-by: Andreas Beckmann <anbe@debian.org>
Link: https://bugs.debian.org/1001083
Link: https://lore.kernel.org/linux-kbuild/CAK7LNAR-VXwHFEJqCcrFDZj+_4+Xd6oynbj_0eS8N504_ydmyw@mail.gmail.com/
Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Makefile