net: mirror skb frag ref/unref helpers
authorMina Almasry <almasrymina@google.com>
Wed, 10 Apr 2024 19:05:02 +0000 (12:05 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 12 Apr 2024 02:29:23 +0000 (19:29 -0700)
commita580ea994fd37f4105028f5a85c38ff6508a2b25
tree1cf42254477023e515e9ab8287988b3c0deba39f
parentf6d827b180bda01f8805bf5e85307419b0d6f890
net: mirror skb frag ref/unref helpers

Refactor some of the skb frag ref/unref helpers for improved clarity.

Implement napi_pp_get_page() to be the mirror counterpart of
napi_pp_put_page().

Implement skb_page_ref() to be the mirror of skb_page_unref().

Improve __skb_frag_ref() to become a mirror counterpart of
__skb_frag_unref(). Previously unref could handle pp & non-pp pages,
while the ref could only handle non-pp pages. Now both the ref & unref
helpers can correctly handle both pp & non-pp pages.

Now that __skb_frag_ref() can handle both pp & non-pp pages, remove
skb_pp_frag_ref(), and use __skb_frag_ref() instead.  This lets us
remove pp specific handling from skb_try_coalesce.

Additionally, since __skb_frag_ref() can now handle both pp & non-pp
pages, a latent issue in skb_shift() should now be fixed. Previously
this function would do a non-pp ref & pp unref on potential pp frags
(fragfrom). After this patch, skb_shift() should correctly do a pp
ref/unref on pp frags.

Signed-off-by: Mina Almasry <almasrymina@google.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20240410190505.1225848-3-almasrymina@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
drivers/net/ethernet/sun/cassini.c
drivers/net/veth.c
include/linux/skbuff_ref.h
net/core/skbuff.c
net/tls/tls_device_fallback.c