ALSA: HDA: Early Forbid of runtime PM
authorHarsha Priya <harshapriya.n@intel.com>
Wed, 30 Sep 2020 11:41:39 +0000 (14:41 +0300)
committerTakashi Iwai <tiwai@suse.de>
Wed, 30 Sep 2020 14:52:48 +0000 (16:52 +0200)
commita0645daf16101bb9a6d87598c17e9a8b7bd60ea7
tree59a61c0248b82ca63c4cca82ad45f1cb498c06d2
parentf4794c6064a83d2c57b264bd299c367d172d1044
ALSA: HDA: Early Forbid of runtime PM

For certain codecs (like Realtek), pm_runtime_forbid() is invoked
in the probe function after build_controls(). In a stress test,
its observed occasionally that runtime PM calls are invoked
before controls are built. This causes the codec to be
runtime suspended before probe completes. Because of this, not all
controls are enumerated correctly, and audio does not work until
system is rebooted.

This issue being common across all codecs, pm_runtime_forbid() is
called when the codec object is created to fix this issue.
A codec enables or disables runtime pm in its own probe function.

Multiple stress tests of 2000+ cycles has been done to test the fix.

Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
Signed-off-by: Emmanuel Jillela <emmanuel.jillela@intel.com>
Reviewed-by: Kailang Yang <kailang@realtek.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20200930114140.3839617-2-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_codec.c