e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue
authorVitaly Lifshits <vitaly.lifshits@intel.com>
Sun, 3 Mar 2024 10:51:32 +0000 (12:51 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 27 Mar 2024 18:44:34 +0000 (11:44 -0700)
commit861e8086029e003305750b4126ecd6617465f5c7
tree6908819dc969154e11469e4a5e4c4aa486df8e67
parent6dbdd4de0362c37e54e8b049781402e5a409e7d0
e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue

Forcing SMBUS inside the ULP enabling flow leads to sporadic PHY loss on
some systems. It is suspected to be caused by initiating PHY transactions
before the interface settles.

Separating this configuration from the ULP enabling flow and moving it to
the shutdown function allows enough time for the interface to settle and
avoids adding a delay.

Fixes: 6607c99e7034 ("e1000e: i219 - fix to enable both ULP and EEE in Sx state")
Co-developed-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
Signed-off-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/e1000e/ich8lan.c
drivers/net/ethernet/intel/e1000e/netdev.c