xfs: refactor inode ownership change transaction/inode/quota allocation idiom
authorDarrick J. Wong <djwong@kernel.org>
Fri, 29 Jan 2021 19:32:09 +0000 (11:32 -0800)
committerDarrick J. Wong <djwong@kernel.org>
Wed, 3 Feb 2021 17:18:49 +0000 (09:18 -0800)
commit7317a03df703f7cdae3ae9e9635a0ef45849fe09
treeac751913a2d3a2fe2376ce8459ec814097f7dfa3
parentf2f7b9ff62a28928f6fe2bd55cdb4d4b02ab7477
xfs: refactor inode ownership change transaction/inode/quota allocation idiom

For file ownership (uid, gid, prid) changes, create a new helper
xfs_trans_alloc_ichange that allocates a transaction and reserves the
appropriate amount of quota against that transction in preparation for a
change of user, group, or project id.  Replace all the open-coded idioms
with a single call to this helper so that we can contain the retry loops
in the next patchset.

This changes the locking behavior for ichange transactions slightly.
Since tr_ichange does not have a permanent reservation and cannot roll,
we pass XFS_ILOCK_EXCL to ijoin so that the inode will be unlocked
automatically at commit time.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
fs/xfs/xfs_ioctl.c
fs/xfs/xfs_iops.c
fs/xfs/xfs_trans.c
fs/xfs/xfs_trans.h