perf session: Avoid infinite loop when seeing invalid header.size
authorArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 30 Jul 2019 13:58:41 +0000 (10:58 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 12 Aug 2019 19:26:02 +0000 (16:26 -0300)
commit57fc032ad643ffd018d66bd4c1bd3a91de4841e8
tree71938498bb43106c0cf37f93f6dddcb118350df5
parent272172bd418cc32aa466588150c8001bc229c712
perf session: Avoid infinite loop when seeing invalid header.size

Vince reported that when fuzzing the userland perf tool with a bogus
perf.data file he got into a infinite loop in 'perf report'.

Changing the return of fetch_mmaped_event() to ERR_PTR(-EINVAL) for that
case gets us out of that infinite loop.

Reported-by: Vince Weaver <vincent.weaver@maine.edu>
Tested-by: Vince Weaver <vincent.weaver@maine.edu>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20190726211415.GE24867@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/session.c