mm: mmap: fix fput in error path v2
authorChristian König <christian.koenig@amd.com>
Fri, 9 Oct 2020 13:08:55 +0000 (15:08 +0200)
committerChristian König <christian.koenig@amd.com>
Thu, 19 Nov 2020 09:35:58 +0000 (10:35 +0100)
commit1527f926fd04490f648c42f42b45218a04754f87
treef817599287173a78196d50eacde0320a553d7289
parentf9f92e7c583f9b120bbb09edae6a587b73feb3a9
mm: mmap: fix fput in error path v2

Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..."
adds a workaround for a bug in mmap_region.

As the comment states ->mmap() callback can change
vma->vm_file and so we might call fput() on the wrong file.

Revert the workaround and proper fix this in mmap_region.

v2: drop the extra if in dma_buf_mmap as well

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Andrew Morton <akpm@linux-foundation.org>
Link: https://patchwork.freedesktop.org/patch/399359/
drivers/dma-buf/dma-buf.c
mm/mmap.c