drm/i915/huc: fix leak of debug object in huc load fence on driver unload
authorDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Fri, 11 Nov 2022 00:56:51 +0000 (16:56 -0800)
committerDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Wed, 23 Nov 2022 20:10:28 +0000 (12:10 -0800)
commit02224691cb0f367acb476911bddfa21e2d596ca5
tree92a8154038a8053a7bbf23fd027a0bd937684a22
parent8b7f7a9b10b704ba7d73199ff0f01354e0bad7a5
drm/i915/huc: fix leak of debug object in huc load fence on driver unload

The fence is always initialized in huc_init_early, but the cleanup in
huc_fini is only being run if HuC is enabled. This causes a leaking of
the debug object when HuC is disabled/not supported, which can in turn
trigger a warning if we try to register a new debug offset at the same
address on driver reload.

To fix the issue, make sure to always run the cleanup code.

Reported-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Reported-by: Brian Norris <briannorris@chromium.org>
Fixes: 27536e03271d ("drm/i915/huc: track delayed HuC load with a fence")
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Brian Norris <briannorris@chromium.org>
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221111005651.4160369-1-daniele.ceraolospurio@intel.com
drivers/gpu/drm/i915/gt/uc/intel_huc.c
drivers/gpu/drm/i915/gt/uc/intel_uc.c