From: Chen Zhou <chenzhou10@huawei.com>
Date: Tue, 21 Jan 2020 01:28:27 +0000 (+0800)
Subject: ata: pata_macio: fix comparing pointer to 0
X-Git-Tag: microblaze-v5.7-rc1~200^2~1
X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=ffa302efe84ed8aa84aaf061ec4448036880b934;p=linux-2.6-microblaze.git

ata: pata_macio: fix comparing pointer to 0

Fixes coccicheck warning:

./drivers/ata/pata_macio.c:982:31-32:
	WARNING comparing pointer to 0, suggest !E

Compare pointer-typed values to NULL rather than 0.

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index 1bfd0154dad5..e47a28271f5b 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -979,7 +979,7 @@ static void pata_macio_invariants(struct pata_macio_priv *priv)
 	priv->aapl_bus_id =  bidp ? *bidp : 0;
 
 	/* Fixup missing Apple bus ID in case of media-bay */
-	if (priv->mediabay && bidp == 0)
+	if (priv->mediabay && !bidp)
 		priv->aapl_bus_id = 1;
 }