From: Yang Yingliang Date: Tue, 28 Jun 2022 13:12:59 +0000 (+0800) Subject: net: pcs-rzn1-miic: fix return value check in miic_probe() X-Git-Tag: microblaze-v6.1~144^2~251 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=dbc6fc7e3f76ac8a584cd39f9978d6b41a96e75a;p=linux-2.6-microblaze.git net: pcs-rzn1-miic: fix return value check in miic_probe() On failure, devm_platform_ioremap_resource() returns a ERR_PTR() value and not NULL. Fix return value checking by using IS_ERR() and return PTR_ERR() as error value. Fixes: 7dc54d3b8d91 ("net: pcs: add Renesas MII converter driver") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: Clément Léger Link: https://lore.kernel.org/r/20220628131259.3109124-1-yangyingliang@huawei.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c index 8f5e910f443d..d896961e48cc 100644 --- a/drivers/net/pcs/pcs-rzn1-miic.c +++ b/drivers/net/pcs/pcs-rzn1-miic.c @@ -461,8 +461,8 @@ static int miic_probe(struct platform_device *pdev) spin_lock_init(&miic->lock); miic->dev = dev; miic->base = devm_platform_ioremap_resource(pdev, 0); - if (!miic->base) - return -EINVAL; + if (IS_ERR(miic->base)) + return PTR_ERR(miic->base); ret = devm_pm_runtime_enable(dev); if (ret < 0)