From: Dani Liberman <dliberman@habana.ai>
Date: Mon, 18 Sep 2023 11:48:46 +0000 (+0300)
Subject: drm/xe: proper setting of irq enabled flag
X-Git-Tag: microblaze-v6.10~28^2~20^2~562
X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=dbac286d8529d6debc0f56fa9a3ea26f78826997;p=linux-2.6-microblaze.git

drm/xe: proper setting of irq enabled flag

IRQ enabled flag should be set only after request irq succeeds.

Reviewed-by: Ohad Sharabi <osharabi@habana.ai>
Signed-off-by: Dani Liberman <dliberman@habana.ai>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---

diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
index dec3d518b3fc..e1126eccb50e 100644
--- a/drivers/gpu/drm/xe/xe_irq.c
+++ b/drivers/gpu/drm/xe/xe_irq.c
@@ -579,16 +579,14 @@ int xe_irq_install(struct xe_device *xe)
 		return -EINVAL;
 	}
 
-	xe->irq.enabled = true;
-
 	xe_irq_reset(xe);
 
 	err = request_irq(irq, irq_handler,
 			  IRQF_SHARED, DRIVER_NAME, xe);
-	if (err < 0) {
-		xe->irq.enabled = false;
+	if (err < 0)
 		return err;
-	}
+
+	xe->irq.enabled = true;
 
 	xe_irq_postinstall(xe);