From: Amadeusz Sławiński Date: Thu, 14 Jan 2021 16:36:01 +0000 (-0500) Subject: ASoC: topology: Ensure that needed parameters are set X-Git-Tag: microblaze-v5.13~138^2~1^2^2~55^2~1 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=d40ab86f7db3612074d08a317bdb1eb8ba06a37e;p=linux-2.6-microblaze.git ASoC: topology: Ensure that needed parameters are set As snd_soc_tplg_component_load is exported function, which means it is part of API, there should be checks if it is called with proper parameters. Signed-off-by: Amadeusz Sławiński Link: https://lore.kernel.org/r/20210114163602.911205-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown --- diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index 950c45008e24..0d182a190c98 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -2659,8 +2659,14 @@ int snd_soc_tplg_component_load(struct snd_soc_component *comp, struct soc_tplg tplg; int ret; - /* component needs to exist to keep and reference data while parsing */ - if (!comp) + /* + * check if we have sane parameters: + * comp - needs to exist to keep and reference data while parsing + * comp->dev - used for resource management and prints + * comp->card - used for setting card related parameters + * fw - we need it, as it is the very thing we parse + */ + if (!comp || !comp->dev || !comp->card || !fw) return -EINVAL; /* setup parsing context */