From: José Expósito <jose.exposito89@gmail.com>
Date: Fri, 24 May 2024 13:05:39 +0000 (+0200)
Subject: HID: logitech-dj: Fix memory leak in logi_dj_recv_switch_to_dj_mode()
X-Git-Tag: microblaze-v6.13~652^2~21
X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=ce3af2ee95170b7d9e15fff6e500d67deab1e7b3;p=linux-2.6-microblaze.git

HID: logitech-dj: Fix memory leak in logi_dj_recv_switch_to_dj_mode()

Fix a memory leak on logi_dj_recv_send_report() error path.

Fixes: 6f20d3261265 ("HID: logitech-dj: Fix error handling in logi_dj_recv_switch_to_dj_mode()")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
---

diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
index 3c3c497b6b91..37958edec55f 100644
--- a/drivers/hid/hid-logitech-dj.c
+++ b/drivers/hid/hid-logitech-dj.c
@@ -1284,8 +1284,10 @@ static int logi_dj_recv_switch_to_dj_mode(struct dj_receiver_dev *djrcv_dev,
 		 */
 		msleep(50);
 
-		if (retval)
+		if (retval) {
+			kfree(dj_report);
 			return retval;
+		}
 	}
 
 	/*