From: Nathan Chancellor Date: Fri, 15 Nov 2024 16:10:04 +0000 (-0700) Subject: ubifs: Fix uninitialized use of err in ubifs_jnl_write_inode() X-Git-Tag: microblaze-v6.16~483^2 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=bcdcb115eaed5e988cf37cc9a1dd5f5dd200e927;p=linux-2.6-microblaze.git ubifs: Fix uninitialized use of err in ubifs_jnl_write_inode() Clang warns (or errors with CONFIG_WERROR=y): fs/ubifs/journal.c:986:20: error: variable 'err' is uninitialized when used here [-Werror,-Wuninitialized] 986 | ubifs_ro_mode(c, err); | ^~~ Set err to -EPERM before the call to ubifs_ro_mode() and reuse it in the return statement to resolve the warning. Fixes: 957e1c4e1779 ("ubifs: ubifs_jnl_write_inode: Only check once for the limitation of xattr count") Signed-off-by: Nathan Chancellor Signed-off-by: Richard Weinberger --- diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c index 8e98be642371..36ba79fbd2ff 100644 --- a/fs/ubifs/journal.c +++ b/fs/ubifs/journal.c @@ -983,8 +983,9 @@ int ubifs_jnl_write_inode(struct ubifs_info *c, const struct inode *inode) if (kill_xattrs && ui->xattr_cnt > ubifs_xattr_max_cnt(c)) { ubifs_err(c, "Cannot delete inode, it has too much xattrs!"); + err = -EPERM; ubifs_ro_mode(c, err); - return -EPERM; + return err; } /*