From: Quentin Schulz Date: Mon, 8 Oct 2018 10:07:26 +0000 (+0200) Subject: net: phy: mscc: remove unneeded parenthesis X-Git-Tag: microblaze-v5.0-rc1~24^2~134^2~2 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=b7d373c500cf4009d78db62329c3b7cfba111713;p=linux-2.6-microblaze.git net: phy: mscc: remove unneeded parenthesis The == operator precedes the || operator, so we can remove the parenthesis around (a == b) || (c == d). The condition is rather explicit and short so removing the parenthesis definitely does not make it harder to read. Reviewed-by: Florian Fainelli Reviewed-by: Andrew Lunn Signed-off-by: Quentin Schulz Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c index d304fb4df23c..0ff7803ed16b 100644 --- a/drivers/net/phy/mscc.c +++ b/drivers/net/phy/mscc.c @@ -300,7 +300,7 @@ static int vsc85xx_mdix_set(struct phy_device *phydev, u8 mdix) u16 reg_val; reg_val = phy_read(phydev, MSCC_PHY_BYPASS_CONTROL); - if ((mdix == ETH_TP_MDI) || (mdix == ETH_TP_MDI_X)) { + if (mdix == ETH_TP_MDI || mdix == ETH_TP_MDI_X) { reg_val |= (DISABLE_PAIR_SWAP_CORR_MASK | DISABLE_POLARITY_CORR_MASK | DISABLE_HP_AUTO_MDIX_MASK);