From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon, 1 Jan 2024 19:15:33 +0000 (+0100)
Subject: netfilter: nft_immediate: drop chain reference counter on error
X-Git-Tag: microblaze-v6.10~722^2~8^2
X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=b29be0ca8e816119ccdf95cc7d7c7be9bde005f1;p=linux-2.6-microblaze.git

netfilter: nft_immediate: drop chain reference counter on error

In the init path, nft_data_init() bumps the chain reference counter,
decrement it on error by following the error path which calls
nft_data_release() to restore it.

Fixes: 4bedf9eee016 ("netfilter: nf_tables: fix chain binding transaction logic")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/net/netfilter/nft_immediate.c b/net/netfilter/nft_immediate.c
index fccb3cf7749c..6475c7abc1fe 100644
--- a/net/netfilter/nft_immediate.c
+++ b/net/netfilter/nft_immediate.c
@@ -78,7 +78,7 @@ static int nft_immediate_init(const struct nft_ctx *ctx,
 		case NFT_GOTO:
 			err = nf_tables_bind_chain(ctx, chain);
 			if (err < 0)
-				return err;
+				goto err1;
 			break;
 		default:
 			break;