From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Date: Thu, 13 Jun 2019 15:54:17 +0000 (-0300)
Subject: media: cxd2820r: don't check retval after our own assignemt
X-Git-Tag: microblaze-v5.5-rc1~174^2~138
X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=ae3af6c43c0dfbded90524a7db5b94fb8fee57c6;p=linux-2.6-microblaze.git

media: cxd2820r: don't check retval after our own assignemt

No need to check a retval after we assigned a constant to it.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---

diff --git a/drivers/media/dvb-frontends/cxd2820r_core.c b/drivers/media/dvb-frontends/cxd2820r_core.c
index 5280ba4085e4..d137199e13e6 100644
--- a/drivers/media/dvb-frontends/cxd2820r_core.c
+++ b/drivers/media/dvb-frontends/cxd2820r_core.c
@@ -636,8 +636,7 @@ static int cxd2820r_probe(struct i2c_client *client,
 	if (IS_ERR(priv->client[1])) {
 		ret = PTR_ERR(priv->client[1]);
 		dev_err(&client->dev, "I2C registration failed\n");
-		if (ret)
-			goto err_regmap_0_regmap_exit;
+		goto err_regmap_0_regmap_exit;
 	}
 
 	priv->regmap[1] = regmap_init_i2c(priv->client[1], &regmap_config1);