From: Colin Ian King Date: Thu, 27 Sep 2018 12:17:49 +0000 (+0100) Subject: staging: wilc1000: fix incorrect allocation size for structure X-Git-Tag: microblaze-v5.0-rc1~82^2~249 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=8f6b8ed3b02e3202b062a0d786c1c623f64cad63;p=linux-2.6-microblaze.git staging: wilc1000: fix incorrect allocation size for structure Currently the allocation for str_vals is for the sizeof the pointer rather than the size of the structure. Fix this. Detected by smatch "wilc_wlan_cfg_init() error: not allocating enough data 392 vs 8" Fixes: acceb12a9f8b ("staging: wilc1000: refactor code to avoid static variables for config parameters") Signed-off-by: Colin Ian King Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/wilc1000/wilc_wlan_cfg.c b/drivers/staging/wilc1000/wilc_wlan_cfg.c index 930a3896f4ae..faa001c75681 100644 --- a/drivers/staging/wilc1000/wilc_wlan_cfg.c +++ b/drivers/staging/wilc1000/wilc_wlan_cfg.c @@ -457,7 +457,7 @@ int wilc_wlan_cfg_init(struct wilc *wl) if (!wl->cfg.s) goto out_w; - str_vals = kzalloc(sizeof(str_vals), GFP_KERNEL); + str_vals = kzalloc(sizeof(*str_vals), GFP_KERNEL); if (!str_vals) goto out_s;