From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Date: Sun, 19 Apr 2020 18:51:15 +0000 (+0800)
Subject: soundwire: slave: don't init debugfs on device registration error
X-Git-Tag: microblaze-v5.10~599^2~34^2~16
X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=8893ab5e8ee5d7c12e0fc1dca4a309475064473d;p=linux-2.6-microblaze.git

soundwire: slave: don't init debugfs on device registration error

The error handling flow seems incorrect, there is no reason to try and
add debugfs support if the device registration did not
succeed. Return on error.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Link: https://lore.kernel.org/r/20200419185117.4233-2-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---

diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
index aace57fae7f8..4bacdb187eab 100644
--- a/drivers/soundwire/slave.c
+++ b/drivers/soundwire/slave.c
@@ -68,6 +68,8 @@ static int sdw_slave_add(struct sdw_bus *bus,
 		list_del(&slave->node);
 		mutex_unlock(&bus->bus_lock);
 		put_device(&slave->dev);
+
+		return ret;
 	}
 	sdw_slave_debugfs_init(slave);