From: Zhen Lei Date: Thu, 13 May 2021 13:26:46 +0000 (+0800) Subject: firmware: tegra: Fix error return code in tegra210_bpmp_init() X-Git-Tag: microblaze-v5.15~22^2~6^2~1 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=7fea67710e9f6a111a2c9440576f2396ccd92d57;p=linux-2.6-microblaze.git firmware: tegra: Fix error return code in tegra210_bpmp_init() When call irq_get_irq_data() to get the IRQ's irq_data failed, an appropriate error code -ENOENT should be returned. However, we directly return 'err', which records the IRQ number instead of the error code. Fixes: 139251fc2208 ("firmware: tegra: add bpmp driver for Tegra210") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Signed-off-by: Thierry Reding --- diff --git a/drivers/firmware/tegra/bpmp-tegra210.c b/drivers/firmware/tegra/bpmp-tegra210.c index ae15940a078e..c32754055c60 100644 --- a/drivers/firmware/tegra/bpmp-tegra210.c +++ b/drivers/firmware/tegra/bpmp-tegra210.c @@ -210,7 +210,7 @@ static int tegra210_bpmp_init(struct tegra_bpmp *bpmp) priv->tx_irq_data = irq_get_irq_data(err); if (!priv->tx_irq_data) { dev_err(&pdev->dev, "failed to get IRQ data for TX IRQ\n"); - return err; + return -ENOENT; } err = platform_get_irq_byname(pdev, "rx");