From: weiping zhang <zhangweiping@didichuxing.com>
Date: Thu, 12 Oct 2017 06:57:06 +0000 (+0800)
Subject: scsi: sd: change manage_start_stop to bool in sysfs interface
X-Git-Tag: microblaze-4.16-rc1~371^2~98
X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=623401ee33e42cee64d333877892be8db02951eb;p=linux-2.6-microblaze.git

scsi: sd: change manage_start_stop to bool in sysfs interface

/sys/class/scsi_disk/0:2:0:0/manage_start_stop can be changed to 0
unexpectly by writing an invalid string.

Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index ce9cc7afd095..37daf9a42afe 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -231,11 +231,15 @@ manage_start_stop_store(struct device *dev, struct device_attribute *attr,
 {
 	struct scsi_disk *sdkp = to_scsi_disk(dev);
 	struct scsi_device *sdp = sdkp->device;
+	bool v;
 
 	if (!capable(CAP_SYS_ADMIN))
 		return -EACCES;
 
-	sdp->manage_start_stop = simple_strtoul(buf, NULL, 10);
+	if (kstrtobool(buf, &v))
+		return -EINVAL;
+
+	sdp->manage_start_stop = v;
 
 	return count;
 }