From: Takashi Sakamoto Date: Mon, 9 Dec 2019 15:05:41 +0000 (+0900) Subject: ALSA: fireface: fix return value in error path of isochronous resources reservation X-Git-Tag: microblaze-v5.7-rc1~275^2~29 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=480136343cbe89426d6c2ab74ffb4e3ee572c7ee;p=linux-2.6-microblaze.git ALSA: fireface: fix return value in error path of isochronous resources reservation Even if isochronous resources reservation fails, error code doesn't return in pcm.hw_params callback. Cc: #5.3+ Fixes: 55162d2bb0e8 ("ALSA: fireface: reserve/release isochronous resources in pcm.hw_params/hw_free callbacks") Signed-off-by: Takashi Sakamoto Link: https://lore.kernel.org/r/20191209151655.GA8090@workstation Signed-off-by: Takashi Iwai --- diff --git a/sound/firewire/fireface/ff-pcm.c b/sound/firewire/fireface/ff-pcm.c index 4e3bd9a2bec0..bd91c6ecb112 100644 --- a/sound/firewire/fireface/ff-pcm.c +++ b/sound/firewire/fireface/ff-pcm.c @@ -247,7 +247,7 @@ static int pcm_hw_params(struct snd_pcm_substream *substream, mutex_unlock(&ff->mutex); } - return 0; + return err; } static int pcm_hw_free(struct snd_pcm_substream *substream)