From: Wei Yongjun Date: Tue, 5 Jun 2018 02:42:56 +0000 (+0000) Subject: net/mlx5e: fix error return code in mlx5e_alloc_rq() X-Git-Tag: microblaze-v4.18-rc3~56^2~21 X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=47a6ca3f972f5baf06cd0c9f37d7b5268ade5363;p=linux-2.6-microblaze.git net/mlx5e: fix error return code in mlx5e_alloc_rq() Fix to return error code -ENOMEM from the kvzalloc_node() error handling case instead of 0, as done elsewhere in this function. Fixes: 069d11465a80 ("net/mlx5e: RX, Enhance legacy Receive Queue memory scheme") Signed-off-by: Wei Yongjun Reviewed-by: Tariq Toukan Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index 333d4ed52b94..89c96a0f708e 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -566,8 +566,10 @@ static int mlx5e_alloc_rq(struct mlx5e_channel *c, kvzalloc_node((wq_sz << rq->wqe.info.log_num_frags) * sizeof(*rq->wqe.frags), GFP_KERNEL, cpu_to_node(c->cpu)); - if (!rq->wqe.frags) + if (!rq->wqe.frags) { + err = -ENOMEM; goto err_free; + } err = mlx5e_init_di_list(rq, params, wq_sz, c->cpu); if (err)