From: Colin Ian King <colin.king@canonical.com>
Date: Sun, 27 May 2018 21:23:12 +0000 (+0100)
Subject: ALSA: xen-front: remove redundant error check on ret
X-Git-Tag: microblaze-v4.18-rc3~69^2~2^2~18
X-Git-Url: http://git.monstr.eu/?a=commitdiff_plain;h=3d6246173798fc7a81a69ad3fd0dd55fa1779068;p=linux-2.6-microblaze.git

ALSA: xen-front: remove redundant error check on ret

The error for a -ve value in ret is redundant as all previous
assignments to ret have an associated -ve check and hence it
is impossible for ret to be less that zero at the point of the
check.  Remove this redundant error check.

Detected by CoveritScan, CID#1469407 ("Logically Dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
index d70a62e7f910..102d6e096cc8 100644
--- a/sound/xen/xen_snd_front_evtchnl.c
+++ b/sound/xen/xen_snd_front_evtchnl.c
@@ -351,8 +351,6 @@ int xen_snd_front_evtchnl_create_all(struct xen_snd_front_info *front_info,
 			}
 		}
 	}
-	if (ret < 0)
-		goto fail;
 
 	front_info->num_evt_pairs = num_streams;
 	return 0;